snac2

commit 4c996c76228eff139a879e57c9a2c3b7bc54e101
parent df1b1510b77c1199d22941b9d271d100851a1bcb
Author: Alex Schroeder <alex@gnu.org>
Date:   Wed,  7 Dec 2022 21:55:39 +0100

Fix mentions with one @ sign

In a mention like the following, the old code had a problem: It would
split the name by '@' and get a list of two elements. Since this is
less than three, it would then try to get the domain name from the
href ("social.alexschroeder.ch") and concatenate it with the name,
resulting in "alex@social.alexschroeder.ch@social.alexschroeder.ch".
The reason was that the code expects an initial "@". In that case,
splitting "@alex@social.alexschroeder.ch" would result in three
elements, and no domain name guessing would happen. If, on the other
hand, the name was "@foo" then finding the domain name in the URL and
appending it so that you get @foo@domain.name is the correct solution.

    "tag": [
        {
            "type": "Mention",
            "href": "https://social.alexschroeder.ch/alex",
            "name": "alex@social.alexschroeder.ch"
        }
    ],

The fix consists in prepending an "@" if the name does not start with
"@" and leaving the rest of the code unchanged.

Diffstat:
M
html.c
 | 
1
+

1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/html.c b/html.c
@@ -367,6 +367,7 @@ d_char *build_mentions(snac *snac, char *msg)
 
         if (type && strcmp(type, "Mention") == 0 &&
             href && strcmp(href, snac->actor) != 0 && name) {
+            if (name[0] != '@') name = xs_str_cat(xs_str_new("@"), name);
             xs *l = xs_split(name, "@");
 
             /* is it a name without a host? */