snac2

commit b620fe99fa99bb1658f43741b2d40ce88ff53963
parent e0cc5752b0e66a0ddc26233a053dc95a77d8953f
Author: default <nobody@localhost>
Date:   Fri, 28 Apr 2023 08:28:17 +0200

Ensure the new app client_id is unique.

Diffstat:
M
mastoapi.c
 | 
13
++++++++++++-

1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/mastoapi.c b/mastoapi.c
@@ -1522,9 +1522,20 @@ int mastoapi_post_handler(const xs_dict *req, const char *q_path,
         if (name && ruri) {
             xs *app  = xs_dict_new();
             xs *id   = xs_replace_i(tid(0), ".", "");
-            xs *cid  = random_str();
             xs *csec = random_str();
             xs *vkey = random_str();
+            xs *cid  = NULL;
+
+            /* pick a non-existent random cid */
+            for (;;) {
+                cid = random_str();
+                xs *p_app = app_get(cid);
+
+                if (p_app == NULL)
+                    break;
+
+                xs_free(cid);
+            }
 
             app = xs_dict_append(app, "name",          name);
             app = xs_dict_append(app, "redirect_uri",  ruri);